Phillip

Current build failure due to .apply_affine_transform()

3

The failure (from the CI) occurs at: ```python def test_apply_affine_transforms_paths(self, diffraction_pattern): D = np.array([[1.0, 0.9, 0.0], [1.1, 1.0, 0.0], [0.0, 0.0, 1.0]]) s = Signal2D(np.asarray([[D, D], [D, D]])) static =...

Convention for masks

4

This came up in: https://github.com/pyxem/pyxem/pull/724#discussion_r581242587 For a `mask` array we should be consistent in if `True` is "this pixel should be included in the data" or "this pixel is masked...

Conventions in orix

44

Following on from: https://github.com/pyxem/orix/pull/234#issuecomment-988742635 There are lots of conventions needed to work with orientations. We (the developers) are starting to learn that anything other than extremely well documented conventions will...

Scoping issue for a 1.0 release

12

This is mainly an issue to get the lay of the land in terms of new features people either (a) want or (b) are hoping to implement in a short/medium...

Accommodating symmetry (which applies to Orientations but not Rotations) in the inheritance structure

8

So in #252 and #253 we've run into some issues with passing symmetry through `Orientations` when inherited methods are involved. My strong feeling is that we shouldn't rely on duplicating...

Tidying up the mean method (low priority)

1

Currently we have a .mean() method - I recently stumbled across: https://onlinelibrary.wiley.com/doi/abs/10.1107/S0021889898003914 which we should check agrees with what we have.

Currently, almost everything that inherits from `Object3d` has overwritten `+`,`-`,`*` and `/` but the discussion #138 has suggested that we might want to have a careful think about how these...

Refactor the "random" method of Rotations (low-priority)

2

It currently uses rejection based sampling, I would prefer the method described in: https://mathworld.wolfram.com/HyperspherePointPicking.html

Reorganisation of utils

4

So I got started on the utils folder in #994 and I think I've got a handle on what we have. Broadly `utils` modules fall into three categories. ## Internal...

Currently we are very permissive with our dependencies, I would like (in anticipation of 1.0.0) to tighten them up a bit, broadly aiming for the latest minor version. For now...