Paul Klink

Results 128 comments of Paul Klink

ContentItem.id is writable as of release 2.4.0 Allowing id to be specified when a drag source related operation is started is addressed in PR #716. (Needs cleanup before it can...

PR #716 has been replaced by PR #785.

Hi Luke, I will have a go at answering this (even though I am not a maintainer). First of all, thank-you for the offer. It really is greatly appreciated. My...

Use `addItem()` instead of `addChild()`. For example: ``` const p = item.parent; if (p instanceof Stack) { const pp = p.parent; if (pp instanceof RowOrColumn) { pp.addItem( { type: "component",...

Ahhh I see. Splitting in the orthogonal direction from the parent row/column is not that straight forward. What would really help with that, is a `Stack.insertParentItem(itemConfig: RowOrColumnItemConfig)` function, which inserts...

Glad to see you got it working. I think at this point in time, we could just include the above as a snippet in the documentation. In the future, we...

Thinking more about this, I think that `Tab` should be declared as an interface - not a class. The core of the Golden Layout code interact can with this interface...

Further to @Taaitaaiger in [comment](https://github.com/golden-layout/golden-layout/issues/738#issuecomment-970224984) in #738 Maybe we should supply 2 default Tab implementations. One for desktops and one for mobile. This could be considered as a broader topic...

isClosable needs rework. Refer to #681 and #647 (near end) I have some thoughts about how it should work. These thoughts also encompass how empty stacks could be better handled....

Documentation at [https://golden-layout.com/tutorials/getting-started.html](https://golden-layout.com/tutorials/getting-started.html) is applicable to release 1.5.9. Documentation covering differences between 1.5.9 and 2 is at [https://github.com/golden-layout/golden-layout](https://github.com/golden-layout/golden-layout). (It mentions jQuery is no longer used.) Currently, the best way of...