Paul Klink

Results 128 comments of Paul Klink

> When you close a tab, `removeChild` is called on that tab Yes - however it is also called whenever any other ContentItem (such as RowOrColumn or ComponentItem) is removed....

Whether or not a header button is shown is determined by the code starting at the following line in `stack.ts`: https://github.com/golden-layout/golden-layout/blob/f442a2d669783fb15fea03485d383a55de34e854/src/ts/items/stack.ts#L88 Basically Golden Layout will check 3 Config item headers...

`LayoutConfig.resolve()` is used internally when layouts are loaded to convert from LayoutConfig to ResolvedLayoutConfig. I probably made this change because I could not see a use case where an application...

ok - will make it public again in the next release.

Bug is probably in [`BrowserPopout.createUrl()`](https://github.com/golden-layout/golden-layout/blob/f442a2d669783fb15fea03485d383a55de34e854/src/ts/controls/browser-popout.ts#L289). Note that at the other end, the URL is searched for `gl-window` at [`VirtualLayout.createLayoutManagerConstructorParameters()`](https://github.com/golden-layout/golden-layout/blob/f442a2d669783fb15fea03485d383a55de34e854/src/ts/virtual-layout.ts#L283) Happy to accept a PR which fixes or alternatively, let me...

In GitHub, for public repositories like Golden Layout, you submit changes with Pull Requests. An overview of this process is: 1. Create a [fork](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-forks) of the Golden Layout repository in...

This was a due to a bug in golden-layout (golden-layout/golden-layout#739). This has been fixed in golden-layout release 2.5.0. I have updated golden-layout-ng-app to use golden-layout 2.5.0. This bug should now...

My variation of this issue cropped up again. Realised that it was due to importing `IonicModule` from `@ionic/angular` instead of importing all the individual Ionic components from `@ionic/angular/standalone` (had missed...