Paul Klink

Results 128 comments of Paul Klink

There is no support for finding the `LocationSelector` of each component. You would need to do this yourself. Use code similar to [`LayoutManager.findFirstComponentItemById`](https://github.com/golden-layout/golden-layout/blob/213d30a03fb99a82729bd6db982f562670134e0a/src/ts/layout-manager.ts#L671) to scan all components. (Use `Layout.rootItem` instead...

Handling of page unloading is becoming quite complex. We seem to be moving towards this new [Page Lifecycle API](https://developer.chrome.com/blog/page-lifecycle-api/). With this lifecycle management, you are never really quite sure when...

Implemented in PR #778. Please test. @jonasruth, you can prevent Golden Layout from unloading by, setting the `closePopoutsOnUnload` config setting to false and then using `LayoutManager.closeAllOpenPopouts()` as discussed in the...

@martin31821 - Could you please publish this release. Does not look like it will get any further testing and we do not want publish ready commits to become stale in...

Nearly fixed in PR #776 (see below for regression fix) The problem was that the tabs are stored in the `TabsContainer._tabs` array however the order of elements in this array...

Ignore PR #776. Please test PR #777. This fixes a regression where dropping as a tab would raise an exception.

Hi @cychia-n2n This is discussed in #736

@klongmitre, currently you can only set `id` in a declarative manner within a `LayoutConfig` (ie the parameter passed in `LayoutManager.loadLayout()`. As @martin31821 pointed out, if an `id` is not specified...

Pass a function as the `componentTypeOrFtn` parameter in `LayoutManager.newDragSource()`. See [app.ts](https://github.com/golden-layout/golden-layout/blob/f649e8838e6e347438e690ad8244e388be8b478a/apitest/app.ts#L182) in apitest for an example of how this is done. (You would also include `id` in the `ComponentItemConfig` returned...

Whoops - looks like passing `id` via function callback currently does not work. Callback currently returns a `DragSource.ComponentItemConfig` which is not the same as `ComponentItemConfig`. Ideally it should return a...