Paul Romano
Paul Romano
@gridley Let me know if you'd like to review before we merge.
Ah yes, thanks for bringing that up @gridley. I did talk to the authors of that paper so I'm aware of the issue at hand.
@ebknudsen If it's OK with you, I may do a bit of refactoring on your branch. One thing I wanted to bring up before doing so is the `lower_left_` and...
@ebknudsen I can take care of the Python bit while I'm doing my refactoring. Thanks! > one notion from the beginning was to use a surface/set of surfaces as a...
@ebknudsen I just pushed a major update on this branch. Let me know if you're alright with the changes I've made (happy to iterate with you if it doesn't meet...
One more thought to add — with the generic constraints dictionary, we could also refactor the `only_fissionable` argument from `openmc.stats.Box` to be its own constraint, which would then allow a...
@gridley Thanks for the detailed comments. I pretty much agree with everything you've said. Ideally, the derived classes should _not_ override the `sample` method. However, the problems I ran into...
@gridley I've updated this branch in response to all your excellent comments. Notably, the interaction between the `Source` class and derived classes is now cleaner. Derived classes are required to...
> It uses a few more advanced features of ENDF-6 that breaks the ENDF reader in Openmc @MicahGale can you elaborate on this?
In general, you can't rotate an axis-aligned cylinder/cone and have its class remain the same, which is why you are seeing this behavior. Perhaps the best thing to do would...