Patrick Wilson
Patrick Wilson
@Chandresh-OSI Looks very close but can you check travis? A test may need changes resulting from your last update. Thanks.
@Chandresh-OSI can you squash commits then this should be ready to move forward.
@dhp-denero these should be split up into their own PR's, one for each module. Also you'll want to retain previous commit information, please review the guidelines here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0
/ocabot rebase
> @patrickrwilson, could you do a rebase and force push to trigger the Runboat build? Rebased as requested, all green now
> @rousseldenis Can i take responsability of migrating this module on another PR? I'm ok with that to get this over the finish line, I'm not sure why pre-commit is...
@onurugur Thank you for migrating, it looks like the commit history wasn't pulled over, can you follow the OCA standards for migration found here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0 Also I think there is...
@AmmarOfficewalaSerpentCS can you increase test coverage to make green, then I'll re-review.
When we were looking at this and extending it with our custom module to add product fields, we found that this if statement inside the product_profile.py should be after super...
@moitabenfdz I know this is approved but it won't work correctly without this same fix that is in this PR for v16. https://github.com/OCA/account-invoicing/pull/1703 Can this be applied to this PR?