OCA
[14.0] [NEW] sale_product_approval: New module added in the repo.
@Chandresh-OSI I was testing this on my local instance and couldn't get the 'sale_ok' field to properly set when changing stages. During troubleshooting, if I made the sale_ok not readonly it worked so that seemed to be preventing the field to change properly. I'm testing on enterprise, can you try this on enterprise and see if you see the same issue?
@Chandresh-OSI It mostly works, I can see the exception banner on the SO and the icon on the SO line but the exception activity doesn't seem to be created anymore. Is this on purpose or a bug?
@Chandresh-OSI Tested and works great after the last commit, just need a bit more coverage on tests.
@Chandresh-OSI @patrickrwilson There are some coding issues here that need improvement, can you work on this please?
Also, there is already a feature for exception handling. It should be leveraged, and improved if it doesn't do the Activities already. See https://github.com/OCA/sale-workflow/tree/14.0/sale_exception
@Chandresh-OSI Looks very close but can you check travis? A test may need changes resulting from your last update. Thanks.
@Chandresh-OSI can you squash commits then this should be ready to move forward.
Due to commit squash issue. I have some merge commits in this PR and it is hard to squash individual commits. So I created new PR for the same code.
That doesn't require a new PR that restarts the review process.
You squash commits with git rebase -i and then force push the same branch.
Do you want to reopen and try that?
Reach out to me if you need more details.
...there seems to be an issue with sale_order_carrier_auto_assign that is causing tests to fail: https://app.travis-ci.com/github/OCA/sale-workflow/jobs/536164726#L2357
On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-1647-by-dreispt-bump-nobump, awaiting test results.
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1647-by-dreispt-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@Chandresh-OSI Could you attend comments and solve Travis ?
As you break standard behaviour you need to find a mean to activate or not this behaviour.
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-1647-by-dreispt-bump-nobump, awaiting test results.
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1647-by-dreispt-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-1647-by-dreispt-bump-nobump, awaiting test results.
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1647-by-dreispt-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-1647-by-dreispt-bump-nobump, awaiting test results.
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1647-by-dreispt-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}