Patrick Wilson
Patrick Wilson
@dsolanki-initos unless i'm missing something, Travis is fine with this module but unhappy with aggreement_sale. I'm not sure how to fix that in this PR.
I'm not sure how to fix this, pointers?
I'm fairly certain I did however it's been over a year since I committed this. I will try to take a look at this again but may be a bit...
@dsolanki-initos I removed the tracking: none in test but isn't it failing on agreement_legal module tests and not this one? I could be reading this wrong. 
@emagdalenaC2i thanks for your PR, can you finish it by adding additional test coverage? Then I'll be happy to review.
/ocabot rebase
@rousseldenis I think all your comments have been addressed and ready for a re-review, thanks for your effort.
@Chandresh-OSI I was testing this on my local instance and couldn't get the 'sale_ok' field to properly set when changing stages. During troubleshooting, if I made the sale_ok not readonly...
@Chandresh-OSI It mostly works, I can see the exception banner on the SO and the icon on the SO line but the exception activity doesn't seem to be created anymore....
@Chandresh-OSI Tested and works great after the last commit, just need a bit more coverage on tests.