web icon indicating copy to clipboard operation
web copied to clipboard
verified publisher icon OCA

[14.0][MIG] Migrated a web_widget_timepicker module.

Open AmmarOfficewalaSerpentCS opened this issue 4 years ago • 7 comments

AmmarOfficewalaSerpentCS avatar May 10 '21 07:05 AmmarOfficewalaSerpentCS

@dreispt , @murtuzasaleh , @max3903

Can you please review this PR ?

AmmarOfficewalaSerpentCS avatar May 10 '21 07:05 AmmarOfficewalaSerpentCS

@AmmarOfficewalaSerpentCS can you increase test coverage to make green, then I'll re-review.

patrickrwilson avatar Jun 28 '21 14:06 patrickrwilson

@patrickrwilson ,

This code coverage not fail form my module it;s failing from web_compnay_color, web_access_rule_button

image

AmmarOfficewalaSerpentCS avatar Jul 13 '21 07:07 AmmarOfficewalaSerpentCS

/ocabot merge nobump

dreispt avatar Jul 19 '21 08:07 dreispt

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-1923-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot avatar Jul 19 '21 08:07 OCA-git-bot

Here any issue with a code so I need to fix?

AmmarOfficewalaSerpentCS avatar Oct 01 '21 06:10 AmmarOfficewalaSerpentCS

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions[bot] avatar Sep 08 '24 12:09 github-actions[bot]