Patrick Hulce

Results 308 comments of Patrick Hulce

Confirmed still an issue on 81.0.4026.0 for me as well on macOS. @connorjclark you're running with *exactly* these settings, right? ![image](https://user-images.githubusercontent.com/2301202/72297250-1dccc080-3621-11ea-9c28-726d9d3dd989.png)

not that :) ![image](https://user-images.githubusercontent.com/2301202/72297772-40aba480-3622-11ea-9e37-eb86926b8097.png) also worth noting that simply refreshing the page fixes the issue and uses Apple Color Emoji font again

Feels eerily similar to https://github.com/GoogleChrome/lighthouse/issues/10067 , P1.5 because whatever's going on with DevTools audits deserves a look.

Nice find @connorjclark , possibly https://github.com/GoogleChrome/lighthouse/blob/96eda60804e5d0b10c9e367b964278f5b7d4d91d/lighthouse-core/config/default-config.js#L178 leftover? I wonder if LH cleaned up its blocked patterns instead of just disconnecting it would fix it.

If the source of the issue is a subtle change in resource loading assumptions and one part of Chrome thinks this request should be blocked while another part doesn't actually...

We've decided to split the concerns of https://github.com/GoogleChrome/lighthouse/issues/7208#issuecomment-470996275 into two audits. 1. Existence of headings (this issue). 2. Valid hierarchy of headings (https://github.com/GoogleChrome/lighthouse/issues/9794).

For anyone else struggling here, manually adding `./node_modules/prettier` to your VS Code Workspace settings `prettier.modulePath` and Cmd+Shift+P `Reload Window` was a viable workaround for me.

> but its seems like it only works on the top URL i.e the page been tested. It does not impact/change the resource URLs. Yeah this was intentional to avoid...

OK after revisiting this later. I'm not 100% convinced threading through the build `urlReplacementPatterns` is the best move. I'm still leaning that way but here are some options I see....

Thanks @KnisterPeter ! > And managing the replacement patterns twice could be reduced if the config file is a js file instead of just json or yaml. I'm not sure...