Patrick Arminio comments

Results 663 comments of


                                            Patrick Arminio

ValueError when updating union types syntax per deprecation warning

hi @alimony can you reproduce this on https://play.strawberry.rocks/ ?

Turn `State` into a `Mapping`

This was exactly what I had in mind :D thanks @Kludex!

✨ Automatically map dictionaries to JSON

@YuriiMotov happy for you to add support for `TypeDecorator`, maybe we can ask @tiangolo if he has any opinions first? 😊

✨ Automatically map dictionaries to JSON

@YuriiMotov also doesn't seems like SQLModel does validation for any incoming data? it would be a different behaviour from the rest?

Pydantic Input Types behavior is strange

@przwr can you also try Maybe? https://strawberry.rocks/docs/types/maybe#maybe

Rename modules that have same name as aliases

@bellini666 sounds good to me, I wonder if we should make a code for this? it could be a big breaking change (though, easy to fix)

Rename modules that have same name as aliases

@bellini666 it's mostly make sure people can update easily 😊

Rename modules that have same name as aliases

it should be easy: https://libcst.readthedocs.io/en/latest/codemods.html#libcst.codemod.CodemodCommand

Rename modules that have same name as aliases

@DoctorJohn the underscore pattern is something I've noticed in [httpx](https://github.com/encode/httpx) (and probably other places) Regarding `strawberry.types`, I'm not opposed, but we also need to figure out what to do with...

Rename modules that have same name as aliases

> It looks like they consistently prefix every "private" module, which I personally like more than just prefixing "private" modules which happen to have an "alias". But that would be...