Patrick Arminio

Results 663 comments of Patrick Arminio

@erikwrede @bellini666 can you summarise what you think we should do? :D

Someone mentioned this on Discord not long ago, I wonder if we should still do it? I think I'm worried a bit about having to maintain all the kwargs, but...

@serramatutu do you still want to work on this? just had a look with @bellini666 and @Ckk3 and the code looks sensible but we also want to allow users to...

Maybe adding a `py.typed` file might help https://blog.whtsky.me/tech/2021/dont-forget-py.typed-for-your-typed-python-package/

I'm marking this as a potential good first issue, but I'm happy to help if someone wants to take this and they are stuck with something ^^

@aadityasinha-dotcom sure! feel free to ping me on discord if you need some help :)

@pedroimpulcetto sounds good! it's been a while though, so I don't fully remember the details :D but happy to answer any question you have

Look alright! But I'll do a proper review once we get tests :D

there's some here: https://github.com/strawberry-graphql/strawberry/blob/main/tests/schema/extensions/test_mask_errors.py