starlette icon indicating copy to clipboard operation
starlette copied to clipboard
verified publisher icon encode

Turn `State` into a `Mapping`

Open Kludex opened this issue 2 months ago • 6 comments

  • Closes https://github.com/Kludex/starlette/issues/3005

Kludex avatar Oct 09 '25 08:10 Kludex

@alex-oleshkevich @abersheeran Can you check this, please?

Kludex avatar Oct 09 '25 08:10 Kludex

@alex-oleshkevich @abersheeran Can you check this, please?

All good.

alex-oleshkevich avatar Oct 09 '25 09:10 alex-oleshkevich

@alex-oleshkevich @abersheeran Can you check this, please?

All good.

In the sense that this implementation makes sense, or something different? 🤔

Kludex avatar Oct 09 '25 09:10 Kludex

@alex-oleshkevich @abersheeran Can you check this, please?

All good.

In the sense that this implementation makes sense, or something different? 🤔

We want to have a typed request state and keep backward compatibility. That was achieved, so all is good :)

alex-oleshkevich avatar Oct 09 '25 09:10 alex-oleshkevich

This was exactly what I had in mind :D thanks @Kludex!

patrick91 avatar Oct 10 '25 09:10 patrick91

Hi there! 👋 I’ve added tests to help increase coverage around typed request.state in #3049. This is my first contribution to Starlette (and to open source in general) I’d love to keep contributing in this area to help unblock and accelerate improvements.

PerumallaGiridhar avatar Oct 29 '25 13:10 PerumallaGiridhar