Patrick Arminio
Patrick Arminio
If I recall correct is awaitable is a slow check, also we are calling resolver for all fields, also the ones that might not need it @sentrivana maybe you can...
@patrick91 you're correct with that you can skip the tracing entirely: https://github.com/strawberry-graphql/strawberry/blob/6553c9e3c67249f538cd3af934e78322a24963a7/strawberry/extensions/tracing/opentelemetry.py#L157-L171 I think on our side we could find ways to skip the `isawaitable`, maybe by adding a property...
~~Just as an update, I'm trying to find a way to make the check faster, but my current attempt is surprisingly slower, see: https://github.com/strawberry-graphql/strawberry/pull/3724~~ I've also done some benchmarks on...
@lepture done, the tests are passing locally, I had to rstrip the last `>` to make it work properly 😊
> Ensure all relevant actions are consistently logged to maintain a complete history. Do we also want to keep the actual history? 😊
There's a small issue when pressing CTRL+C:  you can see `^C` (this is sent by the terminal), I have some ideas on how to...
> I like this! We would need some sort of a registry to ensure we don't duplicate enums across types, but other than that it's a very straight-forward devX improvement....
@ryanpetrello do you mean something like this? ```python import strawberry from enum import Enum @strawberry.enum(description="Some description") class IceCreamFlavour(Enum): VANILLA = strawberry.enum_value("vanilla" , description="Vanilla") STRAWBERRY = "strawberry" CHOCOLATE = "chocolate" @strawberry.type...
@ryanpetrello yeah, we should just do that 🤔 this won't work for you, right? ```python import strawberry from enum import Enum class IceCreamFlavour(Enum): VANILLA = strawberry.enum_value("vanilla" , description="Vanilla") STRAWBERRY =...