Anthonios Partheniou

Docs build in google-cloud-datacatalog and google-cloud-batch fail with `Bullet list ends without a blank line; unexpected unindent.`

2

See build log [here](https://github.com/googleapis/google-cloud-python/actions/runs/5798581836/job/15716671443?pr=11539) which shows the docs build failure with error message `Bullet list ends without a blank line; unexpected unindent.`. The issue is that lines in some list...

In PR https://github.com/googleapis/gapic-generator-python/pull/1999 , I attempted to use a symlink in jinja templates but encountered an error message `jinja2.exceptions.TemplateNotFound: %namespace/%name/%version/%sub/services/%service/_shared_macros.j2` We should investigate if symlinks can be used. See https://github.com/googleapis/gapic-generator-python/pull/1999#discussion_r1592955353...

See [this comment](https://github.com/googleapis/gapic-generator-python/pull/1999#discussion_r1586576476) from PR #1999 related to duplication of code to extract the version. https://github.com/googleapis/gapic-generator-python/blob/617222dab9138c8831be349e75e4b65973ba276f/gapic/templates/tests/unit/gapic/%25name_%25version/%25sub/test_%25service.py.j2#L243-L252 > We're using this construct to get the version number of a dependency in...

See [this comment](https://github.com/googleapis/gapic-generator-python/pull/1999/files/6dfa53c9091e0f3c6bdb3991d656703eee010c5c#r1586588815) and [this comment](https://github.com/googleapis/gapic-generator-python/pull/1999/files/6dfa53c9091e0f3c6bdb3991d656703eee010c5c#r1586595551) from PR #1999 related to improving the asserts in unit tests when metadata is tested. https://github.com/googleapis/gapic-generator-python/blob/617222dab9138c8831be349e75e4b65973ba276f/gapic/templates/tests/unit/gapic/%25name_%25version/%25sub/test_macros.j2#L856-L870 See feedback below: 1 - Headers may include...

See https://github.com/googleapis/gapic-generator-python/pull/1991 which was an attempt to add showcase to golden files but is blocked on https://github.com/googleapis/gapic-generator-python/issues/1993. It would be helpful to have showcase in golden files so that we...

Add presubmit to check the docs build on the golden files

1

Right now we have no docs testing for [golden files](https://github.com/googleapis/gapic-generator-python/tree/main/tests/integration/goldens) in this repository. It would be great to have a way to test the docs via bazel rules, similar to...

See the following issues which highlight a regression between 1.59.0 and 1.62.1, inclusive https://github.com/grpc/grpc/issues/36265 https://github.com/grpc/grpc/issues/34672 We should consider excluding this range of gRPC in `setup.py` when `grpcio` is added as...

Related to https://github.com/googleapis/gapic-generator-python/issues/1924 and https://github.com/googleapis/gapic-generator-python/issues/1922, `grpc` should be declared as a direct dependency as [it exists in generated clients](https://github.com/search?q=repo%3Agoogleapis%2Fgapic-generator-python+%22import+grpc%22&type=code).

I had to [manually fix](https://github.com/googleapis/google-cloud-python/pull/11632/commits/4ed9ce60e7f51dfdc94ce7193599e15536fbb11e) a `google-cloud-python` PR that had a comment looking like this: ``` Attributes: enable_geocoding_separation (bool): If true, separate clusters by their geographic region (from geocoding). Uses...

[asset_v1p4beta1](https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-asset/google/cloud/asset_v1p4beta1) hasn't been updated in several years. [The protos no longer exist in googleapis](https://github.com/googleapis/googleapis/tree/master/google/cloud/asset). The obsolete client `google.cloud.asset_v1p4beta1` should be removed.