Philip Arndt comments

Results 161 comments of


                                            Philip Arndt

Bump to version 0.27.0

Thank you @bragboy this solves the problem for me completely

Bump to version 0.27.0

> For those waiting on this PR to be merged, the better option is to remove this gem altogether and instead use (under `group: 'test'`) Thanks @bragboy ! I tried...

Validate lft and rgt should be less then max sequence

Interesting. What do you think @danielmorrison ? This was merged by you from #241

Validate lft and rgt should be less then max sequence

I'd still like to hear from @danielmorrison / @shekibobo if possible please 😄

Validate lft and rgt should be less then max sequence

@botandrose what do you think about this PR?

Add `bundle install` step to the getting started guide

I think we should close this because as of at least Hanami 2.2.1 I couldn't reproduce: ``` ➜ ~ gem install hanami Successfully installed hanami-2.2.1 Parsing documentation for hanami-2.2.1 Installing...

Petition to use Prefixed Ids

Can you give an example please of what we have and what you'd like it to be instead?

History creation timing

You're trying to create two chapters with the same title and save them at the same time, so the second chapter would raise title not unique, is that unexpected? Do...

History creation timing

As an experiment, does this work: ```ruby class Book < ActiveRecord::Base has_many :chapters include FriendlyId friendly_id :title , :use => [:slugged, :history] end class Chapter < ActiveRecord::Base include FriendlyId friendly_id...

History creation timing

Thanks for confirming! Seems like maybe we should replace our `after_save` hook with an `around_save` here: https://github.com/norman/friendly_id/blob/40b899a547624a50dbe44c5f337ef393e04a9152/lib/friendly_id/history.rb#L80 what do you think?