Philip Arndt comments

Results 131 comments of


                                            Philip Arndt

displaying pdf attachment inline, in the view (problem with browsers on Windows)

You're right not an attachment_fu issue. Last I checked you can't display it inline without using some sort of plugin as the browser does what the user wants. Also a...

Emoji support

🤔 Thanks for reporting; I'd love to keep support for Emoji as they're valid characters. Would you be happy to contribute a PR with a test case that passes on...

Fix collision errors when introducing history plugin after the fact

Thank you for redoing this @tarzan 😄

PG::InvalidColumnReference: ERROR: for SELECT DISTINCT, ORDER BY expressions must appear in select list

@brunnossanttos that's all TypeScript code you posted above, so I'm not quite sure how that relates to this issue 😄

Don't call upstream if nothing found via friendly ID search

@corwinstephen thanks I added some suggestions; we can convert this from a guard clause to just use the result of `exists_by_friendly_id?` as that is what we're most interested in here.

Don't call upstream if nothing found via friendly ID search

@corwinstephen it looks to me like there are 16 test failures and they're probably related to us expecting friendly_id to call `super`

`exists?` returns false positives when query string begins with a number

@corwinstephen thanks! Do you think we need to do something like `return false if input.to_i.to_s != input`?

`exists?` returns false positives when query string begins with a number

What I was meaning is that we should be using friendly ID behaviour if the slug is not fully numeric, which is what I meant by `input.to_i.to_s != input` -...

`exists?` returns false positives when query string begins with a number

yes, I _think_ you're right @corwinstephen - if people are using `model.friendly.find` and the slug doesn't exist then we shouldn't then ask the upstream. Would you like to open a...

[regression] to_param does not work as expected when record fails to save and a new slug is set in memory

Stale bot is just a bot - I've marked this as pinned so it won't do it again.