Philip Arndt

Results 161 comments of Philip Arndt

Is it worth adding a spec to https://github.com/refinery/refinerycms/blob/master/core/spec/controllers/refinery/sitemap_controller_spec.rb ?

Seems that this is because `Date#strptime` is forced to use `Time#strptime` when Timecop is active in a project. The issue is really with Ruby's implementation of `Time#strptime` though it is...

> Add `friendly_id_slugs.id` to select statement: won't this conflict with the main table's `id` column?

I think it's good @tarzan @norman can you think of any gotchas here? I've not used the history plugin before.

@pdornfel I'd really love to merge this but CI isn't happy. The corresponding PR for refinerycms-i18n is failing on Ruby 3.0 and 3.2, but not 3.1 🤔 https://github.com/refinery/refinerycms-i18n/pull/104 Any help...

you could probably put code like that in `config/initializers/patch_action_dispatch_request.rb`

Now with more changes

More changes added

README change added

Updated with more changes.