Philip Arndt
Philip Arndt
I've been putting this in my `Gemfile`: ```ruby gem "rack-rewrite" ``` And this in my `config.ru` ```ruby require "rack/rewrite" use Rack::Rewrite do # remove trailing slashes r302 %r{(/.*)/(\?.*)?$}, "$1$2" end...
I'm having the exact same issue and I believe it's down to `Hanami::Router::Trie#find` only evaluating the first possible path that it can go down, and when it doesn't match returning...
@danhealy FYI, looks like `main` is the same as `2.1.x` (0 files changed) so I've updated the PR's base base branch to `main` (which is why there are now 4...
@danhealy This patch works exceedingly well for me! Previously I was using this great code from @katafrakt https://github.com/katafrakt/palaver/blob/d1a31fec7dba6638ec798c419cecf35ce826f28e/lib/palaver/action.rb#L18-L25 but I've been able to remove that and all of my `contract...
@danhealy awesome, I pushed a fix for rubocop offenses to your branch so that CI will not fail on that.
@jodosha @timriley how do you want to handle this? It would be good to get this in for 2.1 but I'll leave that up to you. Either way we should...
> I'll fix the remaining style issues nice, your fixes mirror exactly how I was going to do it.
Woohoo ✅ CI 🎉
`contract do` is what I had before (for many months now, via https://github.com/katafrakt/palaver/blob/d1a31fec7dba6638ec798c419cecf35ce826f28e/lib/palaver/action.rb#L18-L25) and in practice what this meant is that I had a further abstraction over the top of...
Cool - please let me know when you'd like me to test it out with my app 😄