Filip Skokan
Filip Skokan
> > ❗ support for zero-length secret KeyObject > > I am not happy about this, but I also don't see a way around it. > > > ❗ workaround...
Now on the matter of eventually landing this. I propose to https://github.com/nodejs/node/labels/commit-queue-rebase to land the PR in several commits. Also https://github.com/nodejs/node/labels/semver-minor and leave a note to releasers that only some...
I will pick this up again and break down to individual PRs after #43455 when every new WPT fixing PR will visibly show how many tests it fixes.
Split up into #44170, #44171, #44172, #44173, and #44201. Pulling updated WPT will be done after they land to avoid unnecessary conflicts.
Landed in c6c4cdab361d
Landed in 4b7761441e12
Landed in 54ca9c9bfc3a
@sindresorhus would you prefer the first suggestion to be a breaking change in `@sindresorhus/is` or a special case added to `ow`?
@sindresorhus change https://github.com/sindresorhus/is/blob/v4.4.0/source/index.ts#L112-L113 to ``` case 'number': return Number.isNaN(value) ? 'NaN' : 'number'; ```
Ok, ignore #232 then.