node
node copied to clipboard
crypto: fix webcrypto generateKey() AES key length validation error
This PR fixes WebCryptoAPI AES key length validation error behaviour.
Fixes 672 WPTs
Review requested:
- [ ] @nodejs/crypto
CI: https://ci.nodejs.org/job/node-test-pull-request/45977/
CI: https://ci.nodejs.org/job/node-test-pull-request/45987/
Commit Queue failed
- Loading data for nodejs/node/pull/44170 ✔ Done loading data for nodejs/node/pull/44170 ----------------------------------- PR info ------------------------------------ Title crypto: fix webcrypto generateKey() AES key length validation error (#44170) Author Filip Skokanhttps://github.com/nodejs/node/actions/runs/2848925395(@panva) Branch panva:fix-webcrypto-wpt-aes -> nodejs:main Labels crypto, experimental, author ready, needs-ci, review wanted, webcrypto Commits 1 - crypto: fix webcrypto generateKey() AES key length validation error Committers 1 - Filip Skokan PR-URL: https://github.com/nodejs/node/pull/44170 Reviewed-By: James M Snell Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44170 Reviewed-By: James M Snell Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 08 Aug 2022 10:31:54 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44170#pullrequestreview-1070982828 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/44170#pullrequestreview-1071680946 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-08-10T20:07:41Z: https://ci.nodejs.org/job/node-test-pull-request/45987/ - Querying data for job/node-test-pull-request/45987/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
Landed in 54ca9c9bfc3a
Changes in test/wpt/status/WebCryptoAPI.json
seem to break some tests. I will label this w/ "backport-requested"