node
node copied to clipboard
crypto: fix webcrypto EC key namedCurve validation errors
This PR fixes WebCryptoAPI EC namedCurve validation error behaviour.
Fixes 36 WPTs
Review requested:
- [ ] @nodejs/crypto
CI: https://ci.nodejs.org/job/node-test-pull-request/45975/
CI: https://ci.nodejs.org/job/node-test-pull-request/45985/
Commit Queue failed
- Loading data for nodejs/node/pull/44172 ✔ Done loading data for nodejs/node/pull/44172 ----------------------------------- PR info ------------------------------------ Title crypto: fix webcrypto EC key namedCurve validation errors (#44172) Author Filip Skokanhttps://github.com/nodejs/node/actions/runs/2848925395(@panva) Branch panva:fix-webcrypto-wpt-namedcurve -> nodejs:main Labels crypto, experimental, author ready, needs-ci, review wanted, webcrypto Commits 1 - crypto: fix webcrypto EC key namedCurve validation errors Committers 1 - Filip Skokan PR-URL: https://github.com/nodejs/node/pull/44172 Reviewed-By: James M Snell Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44172 Reviewed-By: James M Snell Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 08 Aug 2022 10:36:09 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44172#pullrequestreview-1070984471 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/44172#pullrequestreview-1071682929 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-08-10T20:06:36Z: https://ci.nodejs.org/job/node-test-pull-request/45985/ - Querying data for job/node-test-pull-request/45985/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
Landed in 4b7761441e12
This breaks some tests in the v16.x branch