node
node copied to clipboard
crypto: fix webcrypto deriveBits validations
This PR fixes WebCryptoAPI deriveBits validation error behaviour.
Fixes 512 WPTs
Review requested:
- [ ] @nodejs/crypto
CI: https://ci.nodejs.org/job/node-test-pull-request/45974/
Commit Queue failed
- Loading data for nodejs/node/pull/44173 ✔ Done loading data for nodejs/node/pull/44173 ----------------------------------- PR info ------------------------------------ Title crypto: fix webcrypto deriveBits validations (#44173) Author Filip Skokanhttps://github.com/nodejs/node/actions/runs/2848925395(@panva) Branch panva:fix-webcrypto-deriveBits-validations -> nodejs:main Labels crypto, experimental, author ready, needs-ci, review wanted, webcrypto Commits 1 - crypto: fix webcrypto deriveBits validations Committers 1 - Filip Skokan PR-URL: https://github.com/nodejs/node/pull/44173 Reviewed-By: James M Snell Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44173 Reviewed-By: James M Snell Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 08 Aug 2022 10:40:48 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44173#pullrequestreview-1070984778 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/44173#pullrequestreview-1071674593 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-08-10T14:41:34Z: https://ci.nodejs.org/job/node-test-pull-request/45974/ - Querying data for job/node-test-pull-request/45974/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
Landed in c6c4cdab361d
THis needs backporting to v16.x