panbingkun

Results 183 comments of panbingkun

@cloud-fan Thank you very much for your `suggestions` and `tips`! Also I think the expression `SortArray` can also be simplified using `StaticInvoke`. https://github.com/apache/spark/blob/b98ac058ab8800dfa1fa66aef67ea7e3e96677cd/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala#L1048-L1224 What do you think?

> https://github.com/openjdk/jdk/blob/dfacda488bfbe2e11e8d607a6d08527710286982/src/java.base/share/classes/java/util/Arrays.java#L2146-L2173 > > ``` > /** > * Searches the specified array for the specified object using the binary > * search algorithm. The array must be sorted into...

> > > https://github.com/openjdk/jdk/blob/dfacda488bfbe2e11e8d607a6d08527710286982/src/java.base/share/classes/java/util/Arrays.java#L2146-L2173 > > > ``` > > > /** > > > * Searches the specified array for the specified object using the binary > > >...

> @panbingkun +1 to simplify `SortArray`. Great, let me try to do it. Thanks!

> cc @panbingkun mind helping review this? 🙏 Okay, I'll verify it this morning.

I have verified on the browser `chrome` and `safari`, and now it is displaying correctly. - Before: - After: Thank @xunxunmimi5577 for helping to fix it. Other divs on the...

@xunxunmimi5577 Can you help confirm if there are similar issues with branch-3.5?

I have verified on `branch-3.5` and it also has similar issues, so this PR also needs to be merged into `branch-3.5`.

I will merge this patch to `master` and `branch-3.5` in the afternoon.