[SPARK-49294][UI] Add width attribute for shuffle-write-time checkbox.
Add the width attribute for shuffle-write-time checkbox.
What changes were proposed in this pull request?
The file webui.css has been changed. Add the style for shuffle-write-time-checkbox-div and set the width to be 155 pixels.
Why are the changes needed?
The tip of shuffle-write-time appears in an strange position before this change.
As shown below
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need for testing.
Was this patch authored or co-authored using generative AI tooling?
No.
@xunxunmimi5577 mind adding a screenshot, and filing a JIRA with adding to the PR title? See also https://spark.apache.org/contributing.html
@xunxunmimi5577 mind adding a screenshot, and filing a JIRA with adding to the PR title? See also https://spark.apache.org/contributing.html
Ok,all done.
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
@HyukjinKwon Could you please review this PR? It's a simple change.
cc @panbingkun mind helping review this? 🙏
Okay, I'll verify it this morning.
I have verified on the browser chrome and safari, and now it is displaying correctly.
-
Before:
-
After:
Thank @xunxunmimi5577 for helping to fix it.
Other divs on the page stagepage.js also have similar CSS settings, as follows:
https://github.com/apache/spark/blob/aaf859053c7a6200527e0ae1010a7bbc10727ccf/core/src/main/resources/org/apache/spark/ui/static/webui.css#L348-L374
@xunxunmimi5577 Can you help confirm if there are similar issues with branch-3.5?
I have verified on branch-3.5 and it also has similar issues, so this PR also needs to be merged into branch-3.5.
I will merge this patch to master and branch-3.5 in the afternoon.
I have verified on
branch-3.5and it also has similar issues, so this PR also needs to be merged intobranch-3.5.
Yes, I found this issue in version 3.3.2. Thank you for your help.
Hi @HyukjinKwon, when I merge this PR, the following prompt appears:
Check if the JIRA information is as expected (y/N): y
JIRA is unassigned, choose assignee
[0] loong (Reporter)
Enter number of user, or userid, to assign to (blank to leave unassigned):0
User 'loong' cannot be assigned, add to contributors role and try again? (y/N):
I don't seem to have the permission to add loong as a contributor role.
can you help to add it? 🙏
Already done.
Merged to master & branch-3.5
Thank you for helping with the review @HyukjinKwon, ❤️
Welcome to the Apache Spark community, @xunxunmimi5577 ! I added you to the Apache Spark contributor group and assigned SPARK-49294 to you.
