spark icon indicating copy to clipboard operation
spark copied to clipboard

[SPARK-49294][UI] Add width attribute for shuffle-write-time checkbox.

Open xunxunmimi5577 opened this issue 1 year ago • 2 comments

Add the width attribute for shuffle-write-time checkbox.

What changes were proposed in this pull request?

The file webui.css has been changed. Add the style for shuffle-write-time-checkbox-div and set the width to be 155 pixels.

Why are the changes needed?

The tip of shuffle-write-time appears in an strange position before this change. As shown below MEITU_20240819_105642523

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No need for testing.

Was this patch authored or co-authored using generative AI tooling?

No.

xunxunmimi5577 avatar Aug 18 '24 15:08 xunxunmimi5577

@xunxunmimi5577 mind adding a screenshot, and filing a JIRA with adding to the PR title? See also https://spark.apache.org/contributing.html

HyukjinKwon avatar Aug 19 '24 00:08 HyukjinKwon

@xunxunmimi5577 mind adding a screenshot, and filing a JIRA with adding to the PR title? See also https://spark.apache.org/contributing.html

Ok,all done.

xunxunmimi5577 avatar Aug 19 '24 03:08 xunxunmimi5577

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

github-actions[bot] avatar Nov 28 '24 00:11 github-actions[bot]

@HyukjinKwon Could you please review this PR? It's a simple change.

xunxunmimi5577 avatar Nov 28 '24 14:11 xunxunmimi5577

cc @panbingkun mind helping review this? 🙏

Okay, I'll verify it this morning.

panbingkun avatar Nov 29 '24 00:11 panbingkun

I have verified on the browser chrome and safari, and now it is displaying correctly.

  • Before: image

  • After: image

Thank @xunxunmimi5577 for helping to fix it.

Other divs on the page stagepage.js also have similar CSS settings, as follows: https://github.com/apache/spark/blob/aaf859053c7a6200527e0ae1010a7bbc10727ccf/core/src/main/resources/org/apache/spark/ui/static/webui.css#L348-L374

panbingkun avatar Nov 29 '24 02:11 panbingkun

@xunxunmimi5577 Can you help confirm if there are similar issues with branch-3.5?

panbingkun avatar Nov 29 '24 02:11 panbingkun

I have verified on branch-3.5 and it also has similar issues, so this PR also needs to be merged into branch-3.5. image

panbingkun avatar Dec 02 '24 03:12 panbingkun

I will merge this patch to master and branch-3.5 in the afternoon.

panbingkun avatar Dec 02 '24 03:12 panbingkun

I have verified on branch-3.5 and it also has similar issues, so this PR also needs to be merged into branch-3.5. image

Yes, I found this issue in version 3.3.2. Thank you for your help.

xunxunmimi5577 avatar Dec 02 '24 03:12 xunxunmimi5577

Hi @HyukjinKwon, when I merge this PR, the following prompt appears:

Check if the JIRA information is as expected (y/N): y
JIRA is unassigned, choose assignee
[0] loong (Reporter)
Enter number of user, or userid, to assign to (blank to leave unassigned):0
User 'loong' cannot be assigned, add to contributors role and try again? (y/N):

I don't seem to have the permission to add loong as a contributor role. can you help to add it? 🙏


Already done.

panbingkun avatar Dec 02 '24 08:12 panbingkun

Merged to master & branch-3.5

Thank you for helping with the review @HyukjinKwon, ❤️

Welcome to the Apache Spark community, @xunxunmimi5577 ! I added you to the Apache Spark contributor group and assigned SPARK-49294 to you.

panbingkun avatar Dec 02 '24 10:12 panbingkun