panbingkun
panbingkun
> Hi, @panbingkun. Sorry for delay in the response. As adding this listing of collation functionality is making other changes necessary, I believe it might be good to keep this...
> @panbingkun Could you clarify, please, why do you implement this new command using V1 DataSource but not V2? This just require unnecessary effort for porting it on DataSource V2...
> I think since you have almost done V1 implementation, let's continue with it, and open a task for the migration this command on V2 here Okay, let me to...
The current sql command results are as follows: ```scala (base) ➜ spark-community git:(show_collation_syntax) ✗ sh bin/spark-sql WARNING: Using incubator modules: jdk.incubator.vector Setting default log level to "WARN". To adjust logging...
@mihailom-db @MaxGekk all done!
> LGTM apart from minor version issue I posted before It has been updated. Thank you for your patient review, thank you very much! ❤️
> @panbingkun Could you resolve conflicts, please. Done, thanks!
> @panbingkun It seems the test failure is related to your changes: > > ``` > [info] - SPARK-43119: Get SQL Keywords *** FAILED *** (11 milliseconds) > [info] "...LLATE,COLLATION,COLL[ATIONS,COLLECTION],COLUMN,COLUMNS,COMM..."...
> +1, LGTM. Merging to master. Thank you, @panbingkun and @mihailom-db @uros-db for review. Thanks all @MaxGekk @mihailom-db @uros-db ❤️
> Hi all, sorry for the late review as I've been struggling with the user-facing API. I know we have a lot SHOW commands already but there are known issues:...