panbingkun comments

Results 183 comments of


                                            panbingkun

[SPARK-48590][BUILD] Upgrade netty to `4.1.111.Final`

> Are the failures relevant? Yes, let me continue investigating it.

[SPARK-48590][BUILD] Upgrade netty to `4.1.111.Final`

> Could you rebase to the `master` branch once more? It seems that we passed the CIs except the known flaky tests, @panbingkun . > > ``` > [info] ***...

[SPARK-48590][BUILD] Upgrade netty to `4.1.111.Final`

cc @LuciferYang

[SPARK-48618][SQL] Utilize the `ErrorCode` and `SQLState` returned in SQLException to make errors more accurate

cc @cloud-fan @yaooqinn @HyukjinKwon

[SPARK-48618][SQL] Utilize the `ErrorCode` and `SQLState` returned in SQLException to make errors more accurate

also cc @MaxGekk

[SPARK-48549][SQL] Restrict the number of parameters for function `sentences` to `1` or `3`

After the pr: - When the number of the parameters is `2`, an error message is prompted: - dataset's head has been corrected:

[SPARK-48549][SQL] Restrict the number of parameters for function `sentences` to `1` or `3`

cc @HyukjinKwon @cloud-fan

[SPARK-48549][SQL] Restrict the number of parameters for function `sentences` to `1` or `3`

also cc @MaxGekk

[SPARK-48549][SQL] Restrict the number of parameters for function `sentences` to `1` or `3`

> Do we have a strong reason to make this breaking change? How bad is it when calling `sentences` with two parameters? Mainly because the inconsistent use of function `sentences`...

[SPARK-48549][SQL] Restrict the number of parameters for function `sentences` to `1` or `3`

> We **shall not break** existing SQL user's code only because it is inconsistent to Scala/Python APIs. As I said let's document the existing behaviour of SQL func first of...