Povilas Kanapickas comments

Results 415 comments of


                                            Povilas Kanapickas

Error binding port when port forwarding even though existing port is outgoing

Please let me know if this is not by design. I will look into this problem when I have time, if no one else fixes it before me. Thanks!

fix failed recognition of custom containerfile due to Windows paths (e.g `C:\some\path`) being misinterpreted as git urls

@metroite Seems that the PR does not contain any changes.

Document Python 3.8 requirement

It's actually python 3.9, we would run 3.8 in CI if it's supported.

Include the service name in the error message when it's extends does …

Thanks for the PR. What are the reproduction steps for the bug this PR is trying to fix?

net/tls: Wait for data_{source,sink}::close()

Rebased and removed accidentally added whitespace changes

github: Setup tests for both rootful and rootless modes

Running rootless on bookworm locally tells me: ``` Error: unable to start container d90ce391f1318dfce16717a40f80322d76520043b3d8ebbf5513e0709be87524: setting up Pasta: pasta failed with exit code 1: [sh2] | No external routable interface for...

Make rootless integration tests work

CI part is already covered here https://github.com/containers/podman-compose/pull/1261

Add subpath support to volumes with type volume in `--mount` option

Tests can still be added for `mount_desc_to_mount_args`. As for `get_mount_args`, would it be possible to patch `assert_volume` to do nothing for test?

feat(podman-logs): improve logs formatting and behavior like docker-c…

Thanks for the pull request, the basic idea looks great, I just had several nits regarding code style. Could you please also add a newsfragment and an integration test?

tests: add a bare git repository

Would it be possible to reproduce the repository state on each run? I think git commit does expose enough options and environment variables to make the repository reproducible.