Povilas Kanapickas comments

Results 416 comments of


                                            Povilas Kanapickas

InfluxDB statistics backend uses an unmantained library

I think Buildbot should not dictate which statistics backend the user infrastructure should use. So I think we'll need to implement both options 2 and 3 at some point.

Modernize Database layer

I think what you wrote is mostly correct. Dataclasses is a welcome addition. One problem with asyncio is that Twisted doesn't work well with it and needs hacks, at least...

Modernize Database layer

> I'll remove the commit, and maybe add a deprecation warning? Yes, please do.

twisted.internet.defer.returnValue() should be removed

pytest-twisted already does not have deferValue: https://github.com/pytest-dev/pytest-twisted/pull/184. This is not released unfortunately yet.

twisted.internet.defer.returnValue() should be removed

OpenDKIM PR https://github.com/trusteddomainproject/OpenDKIM/pull/237.

twisted.internet.defer.returnValue() should be removed

magic-wormhole-mailbox-server PR https://github.com/magic-wormhole/magic-wormhole-mailbox-server/pull/52

twisted.internet.defer.returnValue() should be removed

[libervia-pubsub](https://repos.goffi.org/libervia-pubsub) and [libervia-backend](https://repos.goffi.org/libervia-backend) patches have been sent via email.

Use shared ownership for routes

I will add a test that produces the linked asan report.

db: LogsConnectorComponent.compressLog run compression outside DB thread

A couple of comments before I do full review: > Did not add a newsfragment. It's neither a bug nor feature, but might be worth to mention it anyway in...

db: LogsConnectorComponent.compressLog run compression outside DB thread

> This will probably hurt performance in simple scenarios (master instances without much to do). Please fix my understanding where I'm incorrect. With the changes in this PR we basically...