Povilas Kanapickas
Povilas Kanapickas
See analysis here https://github.com/twisted/twisted/issues/12467#issuecomment-2955458914. pytest patches `twisted.python.failure.Failure.__init__` and it breaks in Twisted 25.5 because there's an additional `except/raise` pair in Twisted test framework code.
@cmarqu @ktbarrett Just a friendly ping..
@ktbarrett The PR is ready for a review again.
> I was considering dropping the DeprecationWarnings on the LogicArray interfaces until 2.1, so there's at least one release where there's no warning, but then we have the same issue...
> Should we still do a release of the current state which supports older cocotb versions? The PR still supports the older cocotb versions, so there's need for new release...
@mattock Thanks for the pull request. As I understand, list didn't work, right? I think this behavior is a bug and we should fix it (not necessarily you).
@mattock Many thanks for pointing this out. I think this PR needs a release note in newsfragments directory, like in this commit 4c21a0667c3080480481936d5b269e066ca528c6.
This PR has been landed via https://github.com/buildbot/buildbot/pull/8187. Thanks a lot for contributing the fix.
Does this actually work? Buildbot does not use subprocess.
Closing the PR as there was no response to comment. Please reopen in case this PR is still interesting.