buildbot icon indicating copy to clipboard operation
buildbot copied to clipboard
verified publisher icon buildbot

Fix Scheduler documentation regarding the "owner" property

Open mattock opened this issue 1 year ago • 3 comments

This fixes https://github.com/buildbot/buildbot/issues/5380

mattock avatar Oct 01 '24 10:10 mattock

@mattock Thanks for the pull request. As I understand, list didn't work, right? I think this behavior is a bug and we should fix it (not necessarily you).

p12tic avatar Oct 01 '24 18:10 p12tic

@p12tic a list does not work. According to @tardyp in https://github.com/buildbot/buildbot/issues/5380 a list is not supposed to work:

I think the doc is wrong. and the previous behaviour was wrong. This is why I fixed it when working on buildbot 1.0. I forgot to update the doc :-} Owner is singular. this does not make sense that it is possible to add a list

If I interpret all this correctly then fixing the documentation is the proper fix.

mattock avatar Oct 17 '24 10:10 mattock

@mattock Many thanks for pointing this out.

I think this PR needs a release note in newsfragments directory, like in this commit 4c21a0667c3080480481936d5b269e066ca528c6.

p12tic avatar Oct 19 '24 10:10 p12tic

This PR has been landed via https://github.com/buildbot/buildbot/pull/8187. Thanks a lot for contributing the fix.

p12tic avatar Nov 04 '24 00:11 p12tic