Orgad Shaneh comments

Results 411 comments of


                                            Orgad Shaneh

> I'd rather move a null check to the beginning of the function? `GIT_ASSERT_ARG(value)`? Done

The failure is: ``` Killed signal terminated program cc1plus ``` I don't see how that's related to any of my changes.

How about now? You can build with `./build-docker.sh`, and it should use the current version.

Rebased. @davehorton ping.

ping

Rebased

@davehorton

I'll try to improve it and use internals instead of AsyncResource.

I didn't find a better solution. Open for suggestions :)

@mcollina Any comments?