Orgad Shaneh
Orgad Shaneh
Adapted redis to v4.
@Larhzu Tested. I verified that latest master fails, and then I built the rhel9landlock branch and got this: ``` $ strace -o s.txt ./xz -V xz (XZ Utils) 5.8.1 liblzma...
If you add this before all other requires in `node-live.js` example, and use Node 20, it fails: ```js const { WebSocket } = require('ws'); global.WebSocket = WebSocket; ``` We have...
Is it possible to fix this on the server? See https://github.com/websockets/ws/pull/2244#issuecomment-2245214238
It's exactly where you pointed. `NATIVE_WEBSOCKET_AVAILABLE` is true if `WebSocket` is defined. Since I assign `global.WebSocket = WebSocket` then in my case it is defined. I use the default deepgram...
While I see your point, he is right that servers should conform to the RFC and not make assumptions about the input. The performance overhead is negligible for this kind...
I have to say that actually *stripping out* the space should have performance impact more than handling a header without a space. Did you check the server logic?
@lukeocodes In my case, it won't help, because I use v8, and I assign the global `WebSocket` to v8. If nobody else complained, I don't think you have a reason...
Dup of #1271. PR: - #1272