Orgad Shaneh comments

Results 411 comments of


                                            Orgad Shaneh

Enable a mixture of server-mode and client-mode operation simultaneously

@pwinckles Can you please attach the scripts you test with, if possible also with their other parties?

Enable a mixture of server-mode and client-mode operation simultaneously

Rebased and replaced `NULL` with `nullptr`. I cannot reproduce your issue. Waiting for inputs.

Enable a mixture of server-mode and client-mode operation simultaneously

I see. Thanks for the information.

Enable a mixture of server-mode and client-mode operation simultaneously

> @orgads Line 2195 in sipp.cpp needs to be changed to: > > ``` > if (creationMode == MODE_CLIENT || creationMode == MODE_MIXED) { > ``` Done, thanks. @dmbhatti I'm...

Not really tested. Tried my best with conflict resolution. The hardest file was install.js, so please review it carefully. Notice I mocked process.release and called `downloadNodeLib` twice for Windows (for...

Sync upstream changes

If you prefer a rebased version (as requested in #136) see https://github.com/nodejs/node-gyp/compare/main...orgads:nw-gyp:rebase?expand=1

journal: replace truncating with punching holes (v252)

ping

darchtio-srf types are not correctly exported using TS

Proposed fix: - #185

darchtio-srf types are not correctly exported using TS

@davehorton what do you prefer? Keep the types here or create a package in DefinitelyTyped?