Orgad Shaneh

Results 411 comments of Orgad Shaneh

Only files that are listed as SOURCES (for any target) are shown in the project tree on Qt Creator. So I just picked the first target I found :) Maybe...

I'm not sure how to add tests for this.

> I don't think changing the format of that data is going to make existing users of this happy. I would prefer to have users opt-in to have spaces treated...

I added the internal quotes following your previous review. The output looks reasonable to me. Do you have a better alternative? Do you prefer changing the default prefix to something...

Ok, reverted to the first revision (no extra quotes in the output).

It build good, but you cannot execute curl directly from src. This change moves licurl.dll to src, which enables execution of curl from there.

CMake build on linux sets rpath, so it's possible to run from `src`. Why do you care where the dll is located? This is only in the build directory, it...

> * installing is optional (esp on Windows), so there is fair chance some scripts/people do their own thing and expect files to be in certain locations. These would need...