Pedro

Results 105 comments of Pedro

Update cc_toolchain_config_lib.bzl for bazelbuild/bazel#10967

copybara should have merged, I will try again. @Yannic could you please sync?

Update cc_toolchain_config_lib.bzl for bazelbuild/bazel#10967

Synced version already merged.

Added cc_library_func(), a function for cc_library()-like semantics.

Closing stale PR. Starlark API is stable now.

Add --collect_coverage_wrapper CLI flag

@c-mita should this PR be closed?

Fix bugs with unicode filenames in runfiles.

This is a nice change but could you please fix the failures on CI?

docs: Mention `layering_check` in header inclusion check docs

Yes, this is correct, @hlopko added support for this a couple of years ago.

--action_env ignored when `cfg = "exec"` is used

It looks like people who are most familiar with this area do not think this is a good idea so closing for now but please feel free to continue the...

Add tool name for objcopy

Is the question related to: https://github.com/bazelbuild/bazel/issues/8438#issuecomment-1766793970 ? If it is, it doesn't look like you need the action name in action_names.bzl.

Add tool name for objcopy

In any case it should be fine to add the action name if you want it for the default toolchain.

CppCompileAction: do not make declaredIncludeSrcs() part of the action key

I agree that the original issue #8319 needs to be addressed. The priority right now is not the highest though, it doesn't happen that often that you add a new...