Pedro
Pedro
I'm not sure we need this, the API should stay fairly stable and I can imagine this function would just start adding more and more parameters until it matches the...
Would users have to write that line or is it part of a file that is automatically generated? I don't mind adding whatever will make it easier but if it...
Aren't we in control of the name of the macro? Can we rename it to something that would be very unlikely to clash with anything?
If the macro name is Rlocation and that may start clashing with people's code in C++ files then I think it would be prudent to rename it if we decide...
@googlewalt would you know the answer to Greg's question?
I thought this could be explained by rewriting cc_library to Starlark but as far as I can see the logic is the same. See [here](https://cs.opensource.google/bazel/bazel/+/master:src/main/starlark/builtins_bzl/common/cc/cc_library.bzl;drc=eb181661ff7e72781f46b7994a5e5c9bab45d5dd;l=239-260) and [here](https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/rules/cpp/CcLibrary.java;drc=3e13f4cbb60bfcd7edd3949184cda42f0785fe54;l=414-435). Is dynamic linking...
@trybka Do you have some background for this?
Adding @c-mita
Hi Chris, I agree with you that if we add more attribute names in the check, it would be getting a bit out of hand. Even hard coding "_cc_toolchain" does...
Looking at this a bit more I can imagine why you sent the change in the first place. First just to document what the problem is, let me rephrase the...