Pedro
Pedro
Alright thanks. I will see if I can get it to reproduce. I think it's unlikely that your custom bazel would introduce any differences.
I forgot to ask, did you see these errors on Linux or macOS?
Hi David, I tried with the same code on macoS, with what I uploaded and the commit before and I can't get it to fail, it always works. Since I...
Glad to hear. Will get it checked in this week. Do you need this checked in before you can confirm the performance benefits in a more realistic setup than the...
It's on top of main now. I guarded the new code path behind a flag so you will have to pass `--experimental_inmemory_sandbox_stashes`
`exports_filter` takes a target pattern but this attribute affects a property of the `cc_shared_library` itself. `LINKABLE_MORE_THAN_ONCE` is a property of each individual `cc_library`, if you do something similar from `cc_shared_library`,...
In my opinion shortening `cc_shared_library/test_cc_shared_library` should be fine. Removing any parent directories would leave the tests in a weird place I think. Not sure if that buys you enough. @pzembrod...
Could you please send a PR for this to the copy of the file in bazelbuild/bazel's bazel_tools so that they are less out of sync? Thanks
> We're talking about updating https://github.com/bazelbuild/bazel/blob/master/tools/cpp/windows_cc_configure.bzl . Correct? Yes. > How do I test that I didn't break anything ? What are the targets I should be building ? We...
Sounds like we can get this in then.