bazel icon indicating copy to clipboard operation
bazel copied to clipboard

docs: Mention `layering_check` in header inclusion check docs

Open fmeum opened this issue 3 years ago • 2 comments

The layering_check feature and toolchain support are required to realize header dependency checking in Bazel. If enabled, this also reports errors for explicitly included transitive, non-direct headers.

Fixes #17055 Fixes #15632

fmeum avatar Dec 20 '22 15:12 fmeum

@oquenchil Could you verify that what I wrote (and deleted) is actually correct? I have seen layering_check work on macOS, but that might have been with the non-Xcode toolchain. If the Xcode toolchain doesn't support layering_check, I would update the docs to reflect that (or try to add support).

fmeum avatar Dec 20 '22 15:12 fmeum

Yes, this is correct, @hlopko added support for this a couple of years ago.

oquenchil avatar Dec 20 '22 16:12 oquenchil

@oquenchil @sgowroji Friendly ping, does this still need to be imported?

fmeum avatar Jan 03 '23 11:01 fmeum

Its imported at https://github.com/bazelbuild/bazel/commit/90eee433f002c8b7a9f4fa6c4d65cb0479296876

sgowroji avatar Jan 03 '23 13:01 sgowroji