bazel icon indicating copy to clipboard operation
bazel copied to clipboard

Throw explicit exception if experimental_split_coverage_postprocessing is used without experimental_fetch_all_coverage_outputs

Open blindpirate opened this issue 3 years ago • 3 comments

This closes https://github.com/bazelbuild/bazel/issues/13185 According to https://github.com/bazelbuild/bazel/commit/e411fa74176cdc54f84d62c189d042e9fb6d5c79, The flag --experimental_split_coverage_postprocessing depends on the flag --experimental_fetch_all_coverage_outputs being enabled, but if the former one is set without the latter one, Bazel throws a quite confusing NullPointerException. Now we throw an explicit exception with proper error message.

blindpirate avatar Aug 21 '22 10:08 blindpirate

Hello @blindpirate, Can you please check build failures. Thank you!

sgowroji avatar Sep 01 '22 05:09 sgowroji

@sgowroji The failure seems to be because CI machine is disconnected from Internet, can you give me some hints how to handle external dependencies which need to be downloaded in integration tests?

blindpirate avatar Sep 01 '22 06:09 blindpirate

Hello @oquenchil, Could you please guide on the above buildkite check failures. Thanks!

sgowroji avatar Sep 19 '22 04:09 sgowroji

Adding @c-mita

oquenchil avatar Sep 27 '22 12:09 oquenchil

Hi @sgowroji @oquenchil @c-mita now it's all green, PTAL!

blindpirate avatar Oct 05 '22 03:10 blindpirate

Thank you @blindpirate !

sgowroji avatar Oct 06 '22 07:10 sgowroji