bazelbuild
Propagate `linkopts` of header-only libraries to `cc_shared_library`
@oquenchil The Windows failure may just be a long path issue. Could we try to use less deeply nested test cases? I don't know how that would interfere with the internal directory layout though.
In my opinion shortening cc_shared_library/test_cc_shared_library should be fine. Removing any parent directories would leave the tests in a weird place I think. Not sure if that buys you enough.
@pzembrod Can you advise Fabian on what the layout should be?
I think shortening cc_shared_library/test_cc_shared_libraryX to cc_shared_library/testX is a good idea, not just okay. I think the context for the tests is absolutely clear enough from the parent directory cc_shared_library so it doesn't need to be repeated in the test directory.
@pzembrod Could you roll back this change? I still haven't found a good solution to https://github.com/bazelbuild/bazel/issues/24518 and I don't think I will have the capacity to investigate this further. It may require adopting new features, e.g. propagating the graph aspect to toolchains.
@pzembrod Could you roll back this change? I still haven't found a good solution to #24518 and I don't think I will have the capacity to investigate this further. It may require adopting new features, e.g. propagating the graph aspect to toolchains.
Sorry, I missed this message. Could I ask you to once eyeball my rollback https://bazel-review.googlesource.com/c/bazel/+/283514 ?