optout
optout
> We had some discussion on [#3741 (comment)](https://github.com/lightningdevkit/rust-lightning/pull/3741#discussion_r2127512308) and on the spec PR ([lightning/bolts#1160 (comment)](https://github.com/lightning/bolts/pull/1160#issuecomment-2942997584)) about this. Turns out we need to make `TxAddInput::prevtx` optional or possible an enum with...
I'm working on shared input support, can be seen in draft PR #3842 . WIP.
Comments addressed, summary of pending changes: - Extra `clone()` added in `channelmanager.rs` when invoking `internal_splice_channel`: root cause addressed in #3835 . - Shared input support: Pending, see #3842. If 3842...
> Let us know when this is ready for another round, no need to wait on #3842 to get more review on this. I was busy with #3842, but I...
Commits squashed, rebased (post #3741), fmt. Ready for a new round of review.
> Also, do you think this could possibly be split up into two commits? First the introduction of the new type, and then switching to it? Or would it cause...
> It is possible to split up into two commits, ... Actually, it's not really possible to separate the external upgrade and the new own implementation: - if external crate...
Thanks for looking into this in detail! You are right that the Default requirement could worked around, but I think the Default trait makes sense for a numerical value, and...
Put back to daft for now, depends on #3234, and it is still open whether to go the route of #3181 .
Pivoted back to reusing `rust-bech32` as much as possible, now in #3244 (following #3234 ).