Onsi Fakhouri

Results 516 comments of Onsi Fakhouri

hey there - I believe the issue is that `--coverpkg` does not support `./...`. Ginkgo does not implement it's own coverage reporting - it's simply using what `go test` does...

You can use `CurrentSpecReport()` however you can only use it during the run phase, not the tree construction phase. i.e. you can call `CurrentSpecReport()` in an `It()` or `BeforeEach()`, but...

Turns out I had some time this morning. I've added `IsSerial` and `IsInOrderedContext` to the `SpecReport` struct. I've also added `.MatchesLabelFilter(query string)` - this takes an arbitrary label filter query...

Yes there can be multiple `BeforeAll` nodes within a single `Ordered` container node. However they have to appear at the top level. i.e. this is allowed: ```go Context("this is ordered",...

Yes, if `Context` is ordered everything in the block is executed in sequence. Nested `BeforeAll`s are valid from a semantic point of view but supporting them would add significant complexity...

All this to say I may eventually implement `BeforeAll` support within nested containers - but I want to get 2.0 out first and can then build on the new feature...

hey @nmiculinic yep those usecases make sense and are why `Ordered` now exists. I'm gonna keep pressing on with 2.0 and have added nester `BeforeAll/AfterAll`to the backlog. will update this...

Well, it proved to be pretty complex because of all the edge cases and interplay with flaky spec retries - but nested `BeforeAll/AfterAll` just landed on the latest ver2.

Looks like I'll be addressing this eventually in v2. I'm planning on making it possible to configure per-suite settings/defaults that the `ginkgo` CLI will honor as it runs through a...

Not quite what this issue is asking for, but on the [ver2](https://github.com/onsi/ginkgo/blob/ver2/docs/MIGRATING_TO_V2.md#using-the-beta) branch you can now mark tests as `Serial`. This will be guaranteed to run in series, never in...