Onsi Fakhouri

Results 516 comments of Onsi Fakhouri

hey @zhaohuxing this looks like it should be a new, different issue. can you open one if you'd like to discuss it further? For now: you don't need separate `TestX`...

hey @Icarus9913 this looks good to me - no concerns at all and happy to defer to you to build it out if you have the time!

i suppose one thing to call out: give the usecase we believe it's sufficient to simply support `AND` with a comma separated list. agreed?

hey there @konopka90 - `RegisterFailHandler` is meant to be called in the `TestX` go test function that calls `ginkgo.RunSpecs` and it primarily exists to connect Ginkgo with Gomega. It’s a...

Can you share your code with me? If you have setup code that should run once before the suite it should go in `BeforeSuite` - not `BeforeAll`. And if you...

Alternatively, if what you want to do is query an external system but only _after_ a failure you can add a `ReportAfterEach`. https://onsi.github.io/ginkgo/#reporting-nodes---reportaftereach-and-reportbeforeeach

hey there - sorry to be the bearer of bad news but mixing standard `go test` tests, examples, and benchmarks into a ginkgo suite doesn't work really well when running...

looping in @nunnatsa who was asking for this as well. i'm going to take a look. they've deprecated `synctest.Run` which would have been easier to manage but I'm going to...

Ideally, though, a spec or container can be decorated with something like `InSynctestBubble` and all the code spawned in all the nodes associated with the test would run within the...

hey @zhulik - glad this new features may be useful for you. You've brought up a few separate things - let me dig into them separately. ### Cleaning up the...