Onsi Fakhouri

Results 306 comments of Onsi Fakhouri

hey there - it looks like you are using the V2 CLI but your test suite is written with Ginkgo V1. You need to use the major version of the...

the v1 cli lives `github.com/onsi/ginkgo/ginkgo` i can imagine the v2 cli identifying that you are running it against a v1 repo and emitting a more useful warning. that could be...

thanks for the kind words y'all. and sorry installing things is giving you trouble. I just ran: ```bash ~ » mkdir foo ~ » cd foo ~/foo » go mod...

hey there - lots to dig into here. First the behavior of `-ginkgo.timeout`: > One downside of it is that it also aborts cleanup operations as soon as those block,...

> How does it abort a running spec, i.e. which mechanism is used to force a Go function to return? Just curious. I wish I _could_ forcibly end the go...

your example doesn't print "stop" because the test process exits after the last `AfterEach` node is "terminated" does that make sense? in Go one goroutine can't cause a different goroutine...

hey @pohly - yes you have it right. I think of suite timeouts as exceptional situations (similar to user-initiated interrupts like sending a `SIGINT`). The intent is to say "the...

> It might be worth calling that out as a caveat in the documentation, if it's not there already. I might have missed it. I'm not sure if it's there...

> Isn't it so that there's always only one active node in a process? Yes, except in this one context where an interrupt/timeout has occurred and Ginkgo is cleaning up...

I have an idea for a design that would allow users to have a per-It timeout as well. Contexts came on the scene after Ginkgo first went GA which is...