Andrey Okonetchnikov

Results 260 comments of Andrey Okonetchnikov

I don’t plan anything for this repo. If you’re interested in adding types, I’d be happy to merge such a PR but I think it will go into another repo.

Yes that would be great. What’s your use case?

Yeah unfortunately I realized later after building this library that using `cloneElement` is very dangerous for exact that reason. In your case I would suggest to start using `attachTo` so...

I’m not sure anymore and the whole thing is better be using the new context api and hooks perhaps so feel free to submit a PR

You're free to fix it and submit a PR! 👍

Feel free to submit a PR that upgrades it to the latest Context API :)

Great @ra2dev! I already left my review. Thanks for it.

You should not touch files that aren't related to the PR I'd suggest.

Build is still failing, though: ``` 12:00:28 PM: 134:36 error Assignment to property of function parameter 'pane' no-param-reassign 12:00:28 PM: 136:12 error Assignment to property of function parameter 'pane' no-param-reassign...

Please send me a PR