react-scroll-sync icon indicating copy to clipboard operation
react-scroll-sync copied to clipboard

Published 20 hours ago • verified publisher icon okonet

enable initial scroll

Open henrysha opened this issue 4 years ago • 5 comments

Per my feature request #41 I have created a fork and allowed initial scroll position through two props initialScrollLeft and initialScrollTop

henrysha avatar Aug 14 '20 07:08 henrysha

@okonet should I get rid of yarn.lock and package-lock.json from the PR?

henrysha avatar Aug 14 '20 09:08 henrysha

You should not touch files that aren't related to the PR I'd suggest.

okonet avatar Aug 14 '20 09:08 okonet

@okonet removed those files from PR

henrysha avatar Aug 14 '20 09:08 henrysha

Build is still failing, though:

12:00:28 PM:   134:36  error  Assignment to property of function parameter 'pane'  no-param-reassign
12:00:28 PM:   136:12  error  Assignment to property of function parameter 'pane'  no-param-reassign
12:00:28 PM:   141:36  error  Assignment to property of function parameter 'pane'  no-param-reassign
12:00:28 PM:   143:12  error  Assignment to property of function parameter 'pane'  no-param-reassign

okonet avatar Aug 14 '20 10:08 okonet

@okonet hey, sorry for the late fix. I have just found out that this has yet to be merged, and I added a eslint ignore to ignore those errors..... Not sure why those errors didn't appear before though.

henrysha avatar Feb 22 '22 18:02 henrysha