react-scroll-sync icon indicating copy to clipboard operation
react-scroll-sync copied to clipboard

Published 20 hours ago • verified publisher icon okonet

Stop using React.Children.only

Open acontreras89 opened this issue 4 years ago • 3 comments

Why is ScrollSync using React.Children.only in its render method? It is a bit inconvenient and I cannot see a reason for it, although I may be missing something..

acontreras89 avatar Jun 05 '20 11:06 acontreras89

I’m not sure anymore and the whole thing is better be using the new context api and hooks perhaps so feel free to submit a PR

okonet avatar Jun 05 '20 15:06 okonet

I think I can do that this week if I find myself with some time to spare at work 🙃

acontreras89 avatar Jun 08 '20 06:06 acontreras89

https://stackoverflow.com/questions/48837831/why-react-children-only

Ethan-Arrowood avatar Aug 04 '20 16:08 Ethan-Arrowood