Petr Ohlídal
Petr Ohlídal
I just took a quick look, it got broken here: https://github.com/RigsOfRods/rigs-of-rods/pull/2949 - specifically this commit https://github.com/RigsOfRods/rigs-of-rods/commit/e583df2cb35197fc7bdc9326908eb9a8aae3cf00. There are actually 2 bugs there: * The "Failed to identify animation source" message...
> Turns out the animations work as intended if a truck is attached and you activate the commands from the truck: @CuriousMike56 I don't really understand how this is working;...
@CuriousMike56 > The problem is that the animations only work when a truck is attached, they should function regardless of connection. Ah, thanks for clarifying, I wasn't sure if that...
Got it. The anims don't activate because they're event-triggered, and input events are only evaluated for trucks (with engine), not trailers. The check is here: https://github.com/RigsOfRods/rigs-of-rods/blob/8d3914b8e0152f1a289c8822ffde16bbc8db8b92/source/main/main.cpp#L1144-L1147 - trailers have type...
Here is the culprit (and yes, skeletonview related): https://github.com/RigsOfRods/rigs-of-rods/blame/master/source/main/physics/ActorManager.cpp#L745-L746 - it broke in https://github.com/RigsOfRods/rigs-of-rods/commit/9431e1b508575c40498ed9becd8a0385a3b95463 - I needed to reset the paused/skeleton after decoupling from the player vehicle. Doesn't make big...
Looks good, is it still WIP or ready for merge?
@AnotherFoxGuy If I understand correctly this only concerns the GitHub workflows build. Rebase it on master and I'll approve it.
My test setup: * Win10 x64, Visual Studio 2022 Community, 17.7.5 (latest) - standard installation via VisualStudioInstaller * cmake 3.27.7 (latest) * Ninja 1.11.1.1 (latest) ## Attempt 1 - basic...
Sorry about the close/reopen, UI focused the Close button while I was typing for some reason. OK, I'll keep that in mind for next time.
I launched the same .cmd script from the Developer Command Prompt, without the paths to compiler. It chose "Hostx86/x86/cl.exe". But then failed without much detail: ``` -- Performing Test DEPS_CHECK...