Nathaniel Wesley Filardo

Can we add `pipe` to the list of modules available in `luac.cross`?

Thank you for your contribution. This feels very... heavy? Enterprise-y? for an embedded system. Just picking on one example, constructing the first error message in `assertReducerShape`, even with an empty...

I know this isn't going to be a hugely popular response, but... our LwIP is *ancient* and a random checkout with Espressif patches lobbed into it and then our own...

> Nathaniel, If you don't mind, I'll give a general review rather than one anchored to PR lines, Though I will add a few specific anchored comments. Any and all...

The intent was to expose callbacks from the Lua layer much as is done now but to limit the direct extensibility of `sntp.lua` itself, again, just as we currently discourage...

I've spent a while more hacking on this and gotten it passing some basic functionality tests. It would be good if someone (esp. @jmattsson) could review it, but I think...

From the LFS-capable end-user perspective, the two are interchangeable. Without LFS, it's hard to imagine NodeMCU as anything but a toy, and so I am not particularly worried about the...

I will make the default success callback in this one DTRT, and will add a simple "just go" function to the module.

OK, I've done a lot more polishing on this and I believe I'm ready to propose that it land. In terms of longer future, I suggest that we leave the...

[Previous incorrect comment deleted] It looks like I removed the LwIP `sntp.c` in c972d86ea9f86794c0d43250f4bc99c3814e0e4c since we had the existing one, which was more aware of the native hardware RTC. And...